-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list, datepicker and textfield component guides #2827
Add list, datepicker and textfield component guides #2827
Conversation
Signed-off-by: Prakhar Gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe in the reference docs we used a hyphen to split words in the file name, date-picker
. Can you verify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the file names are data-grid, date-picker, and file-picker. Ok, so I'll follow the same here.
I pushed a fix, to allow the datePicker to be rendered in a SSR context |
Co-authored-by: Jan Potoms <[email protected]> Signed-off-by: Prakhar Gupta <[email protected]>
Date picker, text field still break: Screen.Recording.2024-02-27.at.3.37.49.PM.mov |
fix added. Also fixed the format in the format demo (had to be uppercase) |
About the missing demo in the list component, I guess we can't add it. So I should just remove it? |
I don't know what it would look like. @bharatkashyap if you have an idea, otherwise we can omit.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge, I'll add this in the release
List: https://deploy-preview-2827--mui-toolpad-docs.netlify.app/toolpad/components/list/
DatePicker: https://deploy-preview-2827--mui-toolpad-docs.netlify.app/toolpad/components/date-picker/
TextField: https://deploy-preview-2827--mui-toolpad-docs.netlify.app/toolpad/components/text-field/